Add IC_BLevels parameter to CX and Varobs writers - #173
Merged
Conversation
Chris Thomas (ctgh)
changed the title
Lee Hawkness-Smith (ldhawknesssmith)
approved these changes
Jun 28, 2023
Lee Hawkness-Smith (ldhawknesssmith)
left a comment
Lee Hawkness-Smith (ldhawknesssmith)
left a comment
Contributor
There was a problem hiding this comment.
Well done finding this. Looks good to me.
Brett Candy (brettcandy)
approved these changes
Jun 28, 2023
Brett Candy (brettcandy)
left a comment
Brett Candy (brettcandy)
left a comment
Contributor
There was a problem hiding this comment.
looks fine
Collaborator
Author
|
Thanks for your reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
IC_BLevelsparameter, which specifies the number of model boundary layer levels.This is necessary for SHPSYN data, for which the wind speed is interpolated to 20m height in VAR.
IC_BLevelsmust be present in the CX header for the interpolation to work correctly.Add the same parameter to the VarObs writer for symmetry and to avoid unintended consequences.