Changes for ufo-2848. - #172
Merged
Merged
Conversation
David Davies (DJDavies2)
requested review from
Chris Thomas (ctgh),
david-rundle,
Michael Cooke (mikecooke77),
mo-keithstewart and
Yaswant Pradhan (yaswant)
June 2, 2023 14:53
Collaborator
Author
|
I don't know what that failure means? |
Collaborator
This is an extra level of protection for opsinputs specific - it indicates that you have not set the "ready to merge" label.
|
Collaborator
Author
|
Okay I have set it. |
Michael Cooke (mikecooke77)
approved these changes
Jun 2, 2023
Michael Cooke (mikecooke77)
left a comment
Michael Cooke (mikecooke77)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me
mo-keithstewart
approved these changes
Jun 5, 2023
Collaborator
|
I've updated description and removed "ready to merge" label as the dependent PRs are still open. Please update the label when appropriate.
|
Yaswant Pradhan (yaswant)
approved these changes
Jun 5, 2023
Chris Thomas (ctgh)
approved these changes
Jun 6, 2023
Collaborator
|
David Davies (@DJDavies2) I see the associated PRs are now in. If you are happy for this to be merged please remove the |
Collaborator
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to be merged alongside https://github.com/JCSDA-internal/ufo/pull/2848 and https://github.com/JCSDA-internal/oops/pull/2212. These are changes suggested by Wojciech Śmigaj (@wsmigaj). Test output is here: http://fcm1/cylc-review/taskjobs/frwd?&suite=oops-2212.
Depends on