Feature/remove c++11 req - #171
Merged
Merged
Conversation
Yaswant Pradhan (yaswant)
marked this pull request as ready for review
May 12, 2023 12:09
Yaswant Pradhan (yaswant)
added
coordinate merge
Chris Thomas (ctgh)
approved these changes
May 12, 2023
David Davies (DJDavies2)
approved these changes
May 12, 2023
Matt Shin (matthewrmshin)
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the hard dependency on c++11 standard. When used in a bundle in conjunction with atlas which requires C++17 features enabled, developers are encouraged to enable C++17 standard at the top-level.
Issues addressed