Make variable names conform for opsinputs - #163
Merged
Yaswant Pradhan (yaswant) merged 6 commits intoApr 27, 2023
Conversation
7 tasks
|
mo-keithstewart - have you tried the new varobs and cx in VAR? |
Contributor
Author
|
Marek Wlasak (@MarekWlasak) - I have run these variable name changes on the latest version of sith and compared the develop version of the code with my changes. This should test these changes with VAR. |
Michael Cooke (mikecooke77)
approved these changes
Apr 18, 2023
Michael Cooke (mikecooke77)
left a comment
Michael Cooke (mikecooke77)
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good to me.
mo-keithstewart
marked this pull request as ready for review
April 18, 2023 15:18
mo-keithstewart
added
waiting on another PR
Steven Sandbach (ss421)
approved these changes
Apr 19, 2023
Steven Sandbach (ss421)
left a comment
Steven Sandbach (ss421)
left a comment
Contributor
There was a problem hiding this comment.
Changes look good - thanks. Ran mo-bundle all tests are passing and can be seen: here.
Steven Sandbach (ss421)
added
coordinate merge
Josh Colclough (mo-joshuacolclough)
approved these changes
Apr 25, 2023
Chris Thomas (ctgh)
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the work required for issue #162 for changes to the variable names so that there is more consistency in the system, as defined in this spreadsheet
The following fields are updated:
theta>>potential_temperaturecloud_area_fraction_in_atmosphere_layer>>cloud_volume_fraction_in_atmosphere_layerliquid_cloud_fraction>>liquid_cloud_volume_fraction_in_atmosphere_layerfrozen_cloud_fraction>>ice_cloud_volume_fraction_in_atmosphere_layerThis fixes an issue we currently have with variable mismatch between different parts of the system.
Acceptance Criteria (Definition of Done)
Test builds and run
Test output is here.
Dependencies
Requires changes to ops-um-jedi, ufo, ufo-data, lfric-lite-jedi, saber, vader and sith