Change the location of pressureAtTopOfCloud because of units - #161
Merged
Conversation
…ent to hPa can be added to the yaml
Michael Cooke (mikecooke77)
requested review from
Brett Candy (brettcandy) and
Toby Searle (twsearle)
March 6, 2023 16:54
Michael Cooke (mikecooke77)
assigned
Michael Cooke (mikecooke77) and unassigned
Toby Searle (twsearle) and
Brett Candy (brettcandy)
Collaborator
Author
|
The change to ufo is in. In order to not break any suites could this change be reviewed asap Toby Searle (@twsearle) and Brett Candy (@brettcandy). Thanks |
Michael Cooke (mikecooke77)
requested review from
Chris Thomas (ctgh) and
Lee Hawkness-Smith (ldhawknesssmith)
March 21, 2023 11:12
Lee Hawkness-Smith (ldhawknesssmith)
approved these changes
Mar 21, 2023
Lee Hawkness-Smith (ldhawknesssmith)
left a comment
Lee Hawkness-Smith (ldhawknesssmith)
left a comment
Contributor
There was a problem hiding this comment.
I'm happy with this simple change as a workaround for JOPA-Var
Toby Searle (twsearle)
approved these changes
Mar 21, 2023
Toby Searle (twsearle)
left a comment
Toby Searle (twsearle)
left a comment
Collaborator
There was a problem hiding this comment.
Sorry! this all looks good to me, I did actually rerun the tests but then I forgot to finish my review. Apologies for the delay
Chris Thomas (ctgh)
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current path for ctp is
OneDVar/pressureAtTopOfCloud. This is being changed to Pa output which matches with the ufo conventions which need to be applied for using retrieved variables in JADA.Therefore a filter has been added to the sith files for iasi, cris and airs to produced a new variable in hPa units at
OutputToVAR/pressureAtTopOfCloudfor use with opsinputs. This saves making unseen changes in opsinputs and can be easily removed when we move to JADA.This needs to be merged after/ along with: