add label checker action - #157
Conversation
Chris Thomas (ctgh)
left a comment
There was a problem hiding this comment.
Looks good! I tested removing and re-adding the label and it seemed to work well.
Michael Cooke (mikecooke77)
left a comment
There was a problem hiding this comment.
Great that we can do this. Could you explain why it has to be skipped if label is present in pr? Why not pass?
Currently, there GitHub action does not support an |
|
That's what I tried in one of the commits, but the action failed to trigger. I did not investigate in detail.. Will try again. |
|
The reason I am pushing is that to make it a JCSDA acceptable solution I think it would need to be a pass rather than skipped. Once we have failed or passed I think they could be persuaded. |
|
Maybe you should take off the label in order to stop a premature merge ;) |
|
I am uncertain (cant verify in this PR) if the "Check Label" badge appears for fresh PR. According to GitHub action documentation this should. Michael Cooke (@mikecooke77) I suggest we merge the changes now and opens a separate issue if it did not function as intended. |
|
One final question before I approve. This will happen for all PRs I think not just ones to develop is that the intention? |
Yes. |
Michael Cooke (mikecooke77)
left a comment
There was a problem hiding this comment.
Please merge
add a label checker action to validate 'ready to merge' label
What this PR does