Add back expected empty output directories.#2
Conversation
There was a problem hiding this comment.
Thanks Todd Jones (@trjr), this looks good to me and I'm happy to merge into main. However, if you could also set up verified commits in future PRs to help our CI pipeline run properly that would be helpful.
|
Ok, Pierre Siddall (@Pierre-siddall). What should I expect for the next step in this process leading to a merge back? |
Hi Todd Jones (@trjr) , I'm happy to merge into main using bypass permissions as the next step in this PR, but if you could follow the guidelines to set up your ssh keys to verify commits to a PR it will ensure that merging into the main branch of any of the simulation systems repositories will not be blocked by the branch protection rules currently being enforced. |
cbd8a55
into
MetOffice:main
PR Summary
Code Reviewer: Pierre Siddall (@Pierre-siddall)
MOSRS vn1.0 trunk intentionally includes a handful of empty directories configured to receive model output. These have been reinstated.
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
Describe what testing has been done here
MONC test configurations now run as expected out of the box.
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Code Review