Skip to content

Add back expected empty output directories.#2

Merged
Pierre Siddall (Pierre-siddall) merged 2 commits into
MetOffice:mainfrom
trjr:main
May 20, 2026
Merged

Add back expected empty output directories.#2
Pierre Siddall (Pierre-siddall) merged 2 commits into
MetOffice:mainfrom
trjr:main

Conversation

@trjr

@trjr Todd Jones (trjr) commented May 1, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Code Reviewer: Pierre Siddall (@Pierre-siddall)

MOSRS vn1.0 trunk intentionally includes a handful of empty directories configured to receive model output. These have been reinstated.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

Describe what testing has been done here

MONC test configurations now run as expected out of the box.

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label May 1, 2026
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels May 1, 2026

@Pierre-siddall Pierre Siddall (Pierre-siddall) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Todd Jones (@trjr), this looks good to me and I'm happy to merge into main. However, if you could also set up verified commits in future PRs to help our CI pipeline run properly that would be helpful.

@trjr

Copy link
Copy Markdown
Contributor Author

Ok, Pierre Siddall (@Pierre-siddall). What should I expect for the next step in this process leading to a merge back?

@Pierre-siddall

Pierre Siddall (Pierre-siddall) commented May 20, 2026

Copy link
Copy Markdown

Ok, Pierre Siddall (Pierre Siddall (@Pierre-siddall)). What should I expect for the next step in this process leading to a merge back?

Hi Todd Jones (@trjr) , I'm happy to merge into main using bypass permissions as the next step in this PR, but if you could follow the guidelines to set up your ssh keys to verify commits to a PR it will ensure that merging into the main branch of any of the simulation systems repositories will not be blocked by the branch protection rules currently being enforced.

@Pierre-siddall Pierre Siddall (Pierre-siddall) merged commit cbd8a55 into MetOffice:main May 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants