Refactor LFRic-XIOS testing infrastructure#358
Open
Ed Hone (EdHone) wants to merge 11 commits into
Open
Conversation
mo-lucy-gordon
left a comment
Contributor
There was a problem hiding this comment.
I think this code looks good, but I am wondering whether it might be good to add/edit a few lines to documentation about the availability and use of the plotting function?
229a948 to
14f6a29
Compare
Contributor
Author
I just added a readme and updated the page in the docs in the latest 2 commits |
mo-lucy-gordon
approved these changes
May 20, 2026
Contributor
|
To Steve Mullerworth (@stevemullerworth) for code review |
Contributor
Author
Potentially to Ricky Wong (@mo-rickywong) now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: mo-lucy-gordon
Code Reviewer: Ricky Wong (@mo-rickywong)
This PR refactors the testing infrastructure of the LFRic-XIOS component, namely by:
PLOT_TEST_OUTPUT=trueenvironment variable.scitoolshas been removed as a module dependency of the compiler technical tests on Met Office machines.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - lfric_core-348-lfx-test-refactor/run5
Suite Information
Task Information
✅ succeeded tasks - 390
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review