Tidying up lfricinputs#434
Merged
Oakley Brunt (oakleybrunt) merged 7 commits intoApr 17, 2026
Merged
Conversation
Harry Shepherd (harry-shepherd)
approved these changes
Apr 17, 2026
Oakley Brunt (oakleybrunt)
approved these changes
Apr 17, 2026
Oakley Brunt (oakleybrunt)
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Harry Shepherd (@harry-shepherd)
Code Reviewer: Oakley Brunt (@oakleybrunt)
This should have no effect on results of any tests, and only adds some logging to the outputs. The main purpose here is to clean up the changeset in #266 so the actual code changes there are more readable
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - t434_lfricinputs_tidy/run2
Suite Information
Task Information
✅ succeeded tasks - 1164
Security Considerations
Performance Impact
AI Assistance and Attribution
Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review