Skip to content

Tidying up lfricinputs#434

Merged
Oakley Brunt (oakleybrunt) merged 7 commits into
MetOffice:mainfrom
mo-lottieturner:lfricinputs_tidy
Apr 17, 2026
Merged

Tidying up lfricinputs#434
Oakley Brunt (oakleybrunt) merged 7 commits into
MetOffice:mainfrom
mo-lottieturner:lfricinputs_tidy

Conversation

@mo-lottieturner

@mo-lottieturner Lottie Turner (mo-lottieturner) commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Sci/Tech Reviewer: Harry Shepherd (@harry-shepherd)
Code Reviewer: Oakley Brunt (@oakleybrunt)

This should have no effect on results of any tests, and only adds some logging to the outputs. The main purpose here is to clean up the changeset in #266 so the actual code changes there are more readable

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - t434_lfricinputs_tidy/run2

Suite Information

Item Value
Suite Name t434_lfricinputs_tidy/run2
Suite User charlotte.turner
Workflow Start 2026-04-16T14:53:12
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.03.1 True
jules MetOffice/jules@2026.03.1 True
lfric_apps mo-lottieturner/lfric_apps@lfricinputs_tidy False
lfric_core MetOffice/lfric_core@2026.03.1 True
moci MetOffice/moci@2026.03.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.03.1 True
socrates MetOffice/socrates@2026.03.1 True
socrates-spectral MetOffice/socrates-spectral@2026.03.1 True
ukca MetOffice/ukca@2026.03.1 True

Task Information

✅ succeeded tasks - 1164

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@mo-lottieturner Lottie Turner (mo-lottieturner) added the LFRic Inputs Changes by/affecting the LFRic Inputs project, including lfric2lfric, lfric2um, scintelapi, um2lfric label Apr 16, 2026
This was referenced Apr 16, 2026
@oakleybrunt Oakley Brunt (oakleybrunt) merged commit 1adae8b into MetOffice:main Apr 17, 2026
6 checks passed
@mo-lottieturner Lottie Turner (mo-lottieturner) linked an issue May 1, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LFRic Inputs Changes by/affecting the LFRic Inputs project, including lfric2lfric, lfric2um, scintelapi, um2lfric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LFRic2UM pseudo-levels

5 participants