Automatically check conda lockfiles are up-to-date and remove unneeded documentation#2209
Merged
Merged
Conversation
This is now checked automatically by pre-commit, so we don't need to ask people to manually check now. New dependencies will still need to be added to the source files, but unit tests should catch that.
James Frost (jfrost-mo)
added
documentation
Contributor
|
|
James Frost (jfrost-mo)
requested review from
David Flack (daflack) and
James Warner (jwarner8)
This file will be updated from here on by the update-dev-deps Makefile target.
James Frost (jfrost-mo)
requested a review
from Sylvia Bohnenstengel (Sylviabohnenstengel)
David Flack (daflack)
approved these changes
Jun 22, 2026
David Flack (daflack)
left a comment
David Flack (daflack)
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense, and is a nice addition to the pre-commits. Happy for it to be merged.
James Frost (jfrost-mo)
removed request for
Sylvia Bohnenstengel (Sylviabohnenstengel) and
James Warner (jwarner8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #2208
Fixes #2207
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.