[EXPERIMENTAL] Conda lockfile update PR to break up later#2199
Closed
James Frost (jfrost-mo) wants to merge 7 commits into
Closed
[EXPERIMENTAL] Conda lockfile update PR to break up later#2199James Frost (jfrost-mo) wants to merge 7 commits into
James Frost (jfrost-mo) wants to merge 7 commits into
Conversation
Contributor
|
|
James Frost (jfrost-mo)
force-pushed
the
check_lockfiles_are_up-to-date
branch
from
a8dd863 to
e405890
Compare
Member
Author
|
TODO: Now this is automatically checked we can remove the bullet point and docs section. |
A script is used to do the updating, which should be reasonably portable. Pre-commit hooks are updated at the same time so this covers all the developer dependencies.
This ensures we are using the same code everywhere.
These tasks are not useful on forks and keep spamming contributors (or at least me) with emails.
We can now do this without reliance on GitHub.
This is now checked automatically by pre-commit, so we don't need to ask people to manually check now. New dependencies will still need to be added to the source files, but unit tests should catch that.
James Frost (jfrost-mo)
force-pushed
the
check_lockfiles_are_up-to-date
branch
from
e405890 to
661b09c
Compare
Member
Author
|
Broken out into separate PRs, so closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.