Extend functionality for MetDB observations and related point-based observation recipe support#2104
Extend functionality for MetDB observations and related point-based observation recipe support#2104ukmo-huw-lewis wants to merge 28 commits into
Conversation
observation recipe support
|
Requesting initial review from David Flack (@daflack), but will keep as draft PR at this stage. Please advise on PR scope, and balance of splitting into smaller chunks, vs review and apply full change-set given dependencies. Note this PR depends on #2161 being reviewed and merged initially, as will help make additional operators added to 'plot.py' more streamlined (i.e. makes use of some changes separated to that PR), plus addition of Note coverage checks fail, but these issues are largely resolved by #2161. Any outstanding gaps in test coverage will be addressed before PR marked as "Ready for review". Note also a dependency on changes to CSET-restricted-files fetch-obs-metdb.py - already reviewed and on main. |
|
As general overview of changes, there are 3 main areas: A) Updates to operators to efficiently process point observations.
|
|
B) addition of new recipes See
|
|
C) Workflow updates to support new observations and introduce more consistent env var naming conventions See updates to Example outputs for UKV vs LM vs LMV comparisons to LNDSYN and WOW observations available at https://wwwspice/~huw.lewis/CSET/LMV_May2026/ Other outputs generated via |
|
Just a few comments from me to think about, as a first go round. I really like the recipes, really simple, clear and straightforward and easy for people to adapt. Potential ideas on splitting the PR: recipes, additional capability, and hexplot addition. Quick question/thought: Is there a conversion file for the names to match the obs with the model as getting from surface_fields? I thought I saw this in an earlier version but it appears to have dropped off. Also wondering what would happen if the surface fields had a large range (e.g. with variables we do not have observations for) as if observation comparisons they would crash so is it worth flagging this up in the documentation/having a separate entry just for observations - although I appreciate that would be a little repetitive from the user perspective so may not be the best idea. Overall, from a science perspective a great, and well needed, addition. I've not looked at it technically, but from what I can tell it looks technically sound, and the evidence you have provided is good. |
Co-authored-by: David Flack <77390156+daflack@users.noreply.github.com>
Addresses #2084
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.