Fix region setup and simplify the bilingual documentation - #90
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af65bc60c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| firmware: data.meta.defaultFirmware || "1.16", | ||
| includeBaseline: true, | ||
| radioProfile: "keep", | ||
| hashMode: ["0", "1", "2"].indexOf(mapParams.get("hash")) !== -1 ? mapParams.get("hash") : "keep", |
There was a problem hiding this comment.
Preserve the wizard step while traversing the map
When an operator reaches step 4, follows Explore regions, and then returns through Configure this region (or switches languages from the map), the incoming step=4 is dropped because this map state never initializes wizardStep, while mapHrefForState() only serializes state.wizardStep. The returned configurator therefore defaults to step 3 instead of restoring the review step; initialize a validated step value here alongside the other handoff settings.
Useful? React with 👍 / 👎.
|
Added the requested Canadaverse entry to the read-only MQTT inventory in English and French in dfa4923, with n30nex@gmail.com as the contact and GTA Regional Tools & CartoLive map as the purpose (translated on the French page). The 14 Analyzer content tests, full content validation, strict build, and checks of both rendered entries passed. This is a documentation update only; no broker accounts or services were changed. GitHub checks are rerunning for this commit. |
Summary
Implements the September English/French site audit on top of merged PR #89.
The audit follow-up maps A01–A17 to changes and verification. Existing community listings, restored guides, build downloads, admin contacts, and subscriber inventory are retained. No region boundaries, broker accounts, or credentials are changed. No new dependencies are added.
Important: gateway before site
The shorter anonymous feedback form needs the gateway update in this PR deployed first. Verify
/configreturnscommunityIdeaOptionalDetails: true, then publish the site. Existing complete v1 submissions and boundary proposals remain compatible. Against an older gateway, the new form offers copy/GitHub fallbacks rather than sending an incompatible request.See the rollout instructions. This PR does not deploy or merge itself.
Verification
All three quality jobs passed for
af65bc6: final workflow run.The final local map regression pass also completed 24 tests across all six browser configurations, including deferred loading, slow boundaries, retry after tile failure, marker images, and keyboard access. English desktop and French mobile layouts were visually checked.
Tests use temporary broker fixtures and simulated submissions, not live broker changes or public test issues.
The performance server now sends HTTP gzip for text assets, matching the verified live GitHub Pages responses. Performance thresholds and the original simulated mobile/desktop throttling profiles are unchanged. The server is bound to localhost and has compression, identity-response, and HEAD regression tests.
Still requires human evidence
Formal registry adoption and proposal #63; missing community contact/profile facts; physical reproduction and safe limits for the unfinished solar builds; infrastructure authentication/retention policy. Those are documented explicitly rather than presented as verified by software tests.