fix(packets): allow loading older filtered results without scrolling - #34
Open
n30nex wants to merge 1 commit into
Open
fix(packets): allow loading older filtered results without scrolling#34n30nex wants to merge 1 commit into
n30nex wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes #33. Packet hash/observer filters can leave zero rows, or too few to scroll. History previously loaded only from the scroll handler, leaving older possible matches unreachable. Add a Load older packets action when another cursor exists and explain that an empty view describes loaded packets.
Manual and scroll paging both wait for any current history request, including background refresh. Existing region, URL filters, cursor queries, live updates and cache limits stay in place. There is no automatic page scan or per-result detail-fetch loop; hash search still filters loaded history.
Type of change
Checklist
npm run buildpasses (the real typecheck)npm run lintpassesnpm testpassesCONTRIBUTING.mdTesting notes
Four regressions fail on the original code on Windows and the Pi. The fix passes all 640 tests in 70 files natively on Pi 5 with Node 24.15.0, plus 47 focused Windows tests. Coverage includes empty/short views, pending requests, retry availability, cursor exhaustion, no automatic scan, existing scrolling and packet/filter wiring. Build and lint pass; the existing TanStack Virtual compiler warning remains.
The Canadaverse preview runs web source
b102cb11fef18c64fea305577fbba39797964f3b; corresponding source and build details are published. Browser checks confirm an empty search can load successive 50-row history pages with advancing cursors, one request per click and no automatic follow-up. The existing server/MQTT containers remained running.Windows' default fork worker timed out; the documented threads pool passed without changing repository configuration. Native lint excludes only the custom generated
dist-publicoutput directory, equivalent to the normal ignoreddistbuild output.AI tools assisted implementation and validation under the contributor's standing approval for this effort.