vendor: move virtual-sx1262 to 28619507 - #20
Merged
Merged
Conversation
The pin was two commits behind and the consumers check in that repository was saying so on every run. It now names the merge of MeshBench/virtual-sx1262#1. What that commit changes is the upstream build.sh: the Windows shared library is linked statically, because linked the default way it imported libstdc++-6.dll and neither emulator could open it on an ordinary Windows machine (MeshBench#632). Nothing in src/ moved. So this bump is a no-op for what this repository produces. build.sh here compiles the model from vendor/virtual-sx1262/src rather than loading the shared library, and already links -static -static-libgcc -static-libstdc++ for Windows, so the fault never reached the native firmware and the fix does not change it either. It is worth taking anyway. A submodule is a commit and nothing moves it on its own, so a pin left behind stays behind - and the next change upstream that does touch src/ should arrive on its own rather than stacked behind an unrelated lag nobody has looked at. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSb8bN9gtL72cXAxtyTbAG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
vendor/virtual-sx1262from0debbb91to28619507, the merge of MeshBench/virtual-sx1262#1.The pin was two commits behind and the
consumerscheck upstream was reporting it on every run:What is in the bump
One commit, and it touches one file:
Upstream's
build.shnow links the Windows shared library statically. Linked the default way it importedlibstdc++-6.dll, which exists inside MSYS2 and almost nowhere else, so neither QEMU nor Renode could open the chip model on an ordinary Windows machine and every emulated board there died as a radio that never answered — MeshBench#632.What it changes here: nothing
Worth being explicit, so nobody reads this as a fix landing.
This repository never had that fault and does not gain anything from its cure.
build.shhere compiles the model from source:rather than loading the shared library the upstream change is about — and for Windows it already links
-static -static-libgcc -static-libstdc++itself. Nothing undersrc/moved, so the compiled firmware is byte-for-byte the same decision it was before.Why take it anyway
A submodule is a commit, and nothing moves it on its own. A pin left behind stays behind indefinitely, and the next upstream change that does touch
src/should arrive on its own rather than stacked behind an unrelated lag nobody has looked at. That is the failure theconsumerscheck was designed to catch, and it caught this one.🤖 Generated with Claude Code
https://claude.ai/code/session_01RSb8bN9gtL72cXAxtyTbAG