Conversation
… not The comment claimed Windows and macOS did not compile and that only linux-amd64 was live. Both have shipped real binaries since August, selected by the PLATFORMS repository variable, which is set to all three. A comment that calls a working path broken costs more than a missing one: the next reader believes the cross-builds are unavailable and reaches for a native runner for each platform, which is the opposite of what this workflow does. The fallback stays at linux-amd64 and now says why, rather than implying it is a limitation. The radioserver note is corrected the same way: nothing blocks it today, and the reason it was never blocked is the part worth keeping. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q9HbD44EKWWTRYgxbFGxf6
Collaborator
Author
|
Superseded: the PLATFORMS repository variable is already set to 'linux-amd64 darwin-arm64 windows-amd64', so releases already carry all three (the v1.17.x native releases have darwin-arm64 and windows-amd64 assets). And this edits RADIOSERVER_PLATFORMS, which #18 removed with radioserver itself. The one still-useful part - the stale 'only linux-amd64 is live' comment - is worth a fresh one-line update on current main rather than a rebase of a conflicting change built around a retired binary. |
A13xB0
added a commit
that referenced
this pull request
Sep 9, 2026
The comment claimed only linux-amd64 was live and the cross-builds did not compile. They do: the v1.17.x native releases carry darwin-arm64 and windows-amd64 too, and the PLATFORMS variable is set to all three. Old MeshCore tags that predate the host port still fail the cross-targets, which is expected and does not block their linux release. The useful half of #11, which conflicted around the retired radioserver. Claude-Session: https://claude.ai/code/session_01Q9HbD44EKWWTRYgxbFGxf6 Co-authored-by: R0ck <random@email.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PLATFORMScomment said the Windows and macOS cross-builds "do not compile yet" and that only linux-amd64 was live. Neither is true: the repository variable is set tolinux-amd64 darwin-arm64 windows-amd64, and the currentmainrelease carries real binaries for all three across every role, cross-built on Ubuntu with LLVM-MinGW.This matters because of what the stale comment invites. Read literally, it tells the next person the cross-builds are unavailable, and the obvious response is to reach for a native runner per platform. That is the opposite of what this workflow already does, and it is the direction the project is deliberately moving away from.
The fallback stays at
linux-amd64and now says why it is narrow rather than implying it is a limitation. The radioserver comment is corrected the same way: nothing blocks it today, and the reason it was never blocked, one translation unit with no Arduino shims and no Crypto, is the part worth keeping.Comment only. No behaviour change, and the YAML parses.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Q9HbD44EKWWTRYgxbFGxf6