merge queue: checking #1834 on main (b4ead66), stacked on #1836 - #1845
Closed
mergify[bot] wants to merge 4 commits into
Closed
mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
flate2 1.1.9 -> 1.1.10, quick-xml 0.41 -> 0.42, jsonschema 0.49 -> 0.55. Supersedes renovate's #1792, which never got past `renovate/artifacts`: the bot regenerates Cargo.lock itself and couldn't, so every downstream job (rust, MSRV, cargo-deny, wheels, smoke tests, ci-gate) was red for want of a lockfile, not a real break in the bump. quick-xml 0.42 replaces its whole byte-oriented name/text API with `&str` (`QName` is now `QName<'a>(pub &'a str)`, and `BytesText` / `BytesCData` / `BytesRef` all implement `AsRef<str>` instead of `AsRef<[u8]>`), since the crate only ever accepted UTF-8 XML anyway. Update the JUnit parser's `local_name()` and every attribute/tag match in junit.rs from byte-string patterns to string patterns to match. jsonschema 0.49 -> 0.55 is six minor versions of a pre-1.0 crate; read the crate's changelog end to end rather than trusting a clean compile. The one behavior-relevant note (0.52.0: with `default-features = false`, `idn-hostname`/`idn-email` need the new `idna` feature or they're unknown formats) doesn't apply here — the Mergify config schema's own `format` keywords (`date-time`, `duration`, `regex`, `simple-template`, `template`) are all custom or already outside that set, so they were unknown formats (silently accepted) before this bump too. No code changes needed for `mergify-config`'s `validate_against_schema`, which only uses `options().build()` / `iter_errors()` / `instance_path()` — none of which changed shape across the six releases. Cargo.lock's other moves (jsonschema-regex, jsonschema-value, referencing pinned in lockstep with jsonschema; fraction and num-bigint pulled in by jsonschema's own updated deps; miniz_oxide and an inactive optional zlib-rs pulled in by flate2) are all forced by these three bumps, not separate dependency moves. Verified locally against the exact CI steps: `cargo fmt --all --check`, `cargo clippy --workspace --all-targets --all-features --locked -- -D warnings`, `cargo test --workspace --all-features --locked` (668 passed), `cargo build --workspace --all-features --locked`, all green. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Change-Id: I34925c0376293e993db7b1048faa55005f3d1b9e
The OpenAI submission portal rejects the plugin with "Subtitle must be 30 characters or fewer". Our shortDescription was 99, so the Info tab could not be filled at all. The subtitle is the one-line label under the plugin name in the directory, not a summary: "Run and debug your merge queue" is exactly 30 and keeps the verb the long description opens with. The longDescription carries everything the old string said about stacks and configuration. The limit is not documented anywhere in developers.openai.com/plugins; it only surfaces on upload. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: Ib967c49ecb872dabe8357eb71898a9cdb3a806be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#1834 is queued for merge on branch main (b4ead66).
Stacked behind 1 pull request queued ahead of this batch, not part of it. These checks run on a tip that also carries its commits, so a failure here can come from it as much as from #1834.
Queued ahead of this batch:
This pull request has been created by Mergify to speculatively check the mergeability of #1834.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub branch protection]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=ci-gateRequired conditions to stay in the queue:
base=maingithub-review-approved[🛡 GitHub branch protection]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]label!=manual mergeEnforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=ci-gate