Repository navigation
fix(translate): accept consecutively reported upstream choices - #711
Merged
Merged
Conversation
Remove the request-count ceiling from output IR construction and Chat event routing while requiring sequential valid indexes. Verify that every upstream choice is retained and skipped indexes still fail.
Keep the reviewed choice-count rationale beside the owning builder and gap assertion. Additional consecutive choices remain valid and skipped indexes remain malformed.
2 tasks done
…cardinality # Conflicts: # packages/translate/__tests__/protocols/edge-cases_test.ts # packages/translate/__tests__/protocols/openai-chat-completions/as-target/events_test.ts # packages/translate/src/protocols/anthropic-messages/via-openai-chat-completions/events.ts # packages/translate/src/protocols/anthropic-messages/via-openai-chat-completions/translate.ts # packages/translate/src/protocols/gemini-generate-content/via-openai-chat-completions/events.ts # packages/translate/src/protocols/gemini-generate-content/via-openai-chat-completions/translate.ts # packages/translate/src/protocols/openai-responses/via-openai-chat-completions/events.ts # packages/translate/src/protocols/openai-responses/via-openai-chat-completions/translate.ts
Menci
marked this pull request as ready for review
November 12, 2026 14:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept consecutive upstream choices beyond the requested count while retaining index validity and sequence checks. Remove the request-count ceiling from the builder and event routing; single-choice client protocols retain their representability checks.
Validated with five named files (142 tests), translate TypeScript and scoped lint. Independent prerequisite for #673.