fix: preserve native space trackpad feedback - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Space-trackpad feedback now follows the observed native states: iOS fades legends and softens key faces, uses a visible gray pressed fill, and restores appearance on release/cancellation. Android keeps the space bar's configured pressed color during cursor dragging. Custom colors remain supported and iOS letter-preview bubbles keep their independent fill.
Adds atomic feedback regressions to the existing CI suites, plus a stationary iPad currency-hold regression. Removes two unused image fixtures and three obsolete manual visual scripts.
The iPad CI failure was in Apple's dollar-hold baseline: the recording showed a highlighted cent sign but a stationary release committed nothing. The UI comparison now explicitly slides into the currency popup, requires
¢, and compares Keyflow's output exactly. Keyflow's stationary hold/release remains covered directly. No retry or skip was added for that failure.Validation