ci: point pnpm action-setup at .github/release/package.json#37
Merged
Conversation
The release tooling's package.json (with the pinned packageManager version) lives under .github/release/, but pnpm/action-setup defaulted to the nonexistent root package.json and failed the version and release jobs with "No pnpm version is specified". Point both steps at the correct file.
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Release workflow fails at the Set up pnpm step with
No pnpm version is specified.pnpm/action-setupreads the pnpm version from thepackageManagerkey inpackage.json, defaulting to the repo root. This repo has no rootpackage.json— the release tooling (and itspackageManager: "pnpm@10.6.4"pin) lives under.github/release/. So the action had no version to install and bailed before Node setup, install, or version determination ran. Fallout from #35.Fix
Point both the
versionandreleasejobs' pnpm steps at.github/release/package.jsonviapackage_json_file. Keeps a single source of truth (the lockfile there already pins the version) rather than duplicating it inline.