Challenges 1 & 2: Pugbnb front page + Pug & Puggle backend schema - #23
Open
J-C-S-V wants to merge 13 commits into
Open
Challenges 1 & 2: Pugbnb front page + Pug & Puggle backend schema#23J-C-S-V wants to merge 13 commits into
J-C-S-V wants to merge 13 commits into
Conversation
…Team, and Testimonial
…s.php to reflect CPT and taxonomy registrations in plugins
Collaborator
|
@steinbachr This one is good for your review. Only thing flagged is the missing ACF guard in plugin challenge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Challenge 1 — Front page
theme/inc/data/featured-cards.php) and rendered via a reusabletemplate-parts/featured-card.phppartial — no hardcoded markup infront-page.php.Challenge 2 — Backend schema
1. Plugins
challenge-2/plugins/pug-puggle-schema/, not in the theme. Reason: content schema should outlive the theme — if the theme is swapped, the post types and stored data persist.2. Custom Post Types (registered in
plugins/pug-puggle-schema/cpt/)practice-areapost_parentteaminc/utils/posts.php)testimonialReviewmarkupofficeLocalBusinessschemalocalregion → city/PAnesting referenced by commented code inservices/locations.phpresultfaqFAQPageschema3. Taxonomies (registered in
plugins/pug-puggle-schema/tax/)area-servedlocal,practice-areatax_queryinservices/locations.phpexpects this taxonomyfaq-categoryfaqattorney-roleteamThe built-in
categorytaxonomy is attached topractice-areaandlocalvia their CPT registrations (thepractice-areaswidget queries it).4. Project structure
cpt/practice-area.php,tax/area-served.php, etc.) wired through smallall.phploaders. Greppable, easy to disable individually, mirrors the existinginc/widgets/pattern.init(CPTs) andinit(taxonomies) — correct hooks so rewrites resolve immediately.Challenge 3
A bit rusty on this one, but still proud! Future updates on the way: better mobile experience, extra preset buttons, and more visual styles 🚀
https://github.com/J-C-S-V/button-builder
@steinbachr