Changed descriptor max to maxhp. Max is a bit ambigious in this case … - #5
Open
rhagelstrom wants to merge 4 commits into
Open
Changed descriptor max to maxhp. Max is a bit ambigious in this case …#5rhagelstrom wants to merge 4 commits into
rhagelstrom wants to merge 4 commits into
Conversation
…and causing confictings with the use of 'max' in FG which generally means maximize the dice roll.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think maxhp makes more sense here for a few reasons:
max is generally thought of as maximize the roll. BCEG allows for heal to use a max descriptor to maximize the roll which ends up conflicting. maxhp is used elsewhere in CA to denote increasing the maxhp so this change seems to get everything a bit more consistent as well as avoid conflict.