fix(slack): retry 5xx and retryable JSON errors on every call - #84
Open
MaximeGaudin wants to merge 1 commit into
Open
fix(slack): retry 5xx and retryable JSON errors on every call#84MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
Match Gmail: GET and POST (including chat.postMessage) retry 429, 5xx, internal_error, and fatal_error. Honour Retry-After. Real errors still fail fast. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal_error/fatal_error, same as existing 429 /ratelimited.chat.postMessage. HonourRetry-After. 401 and other real errors still fail fast.Closes #81
Test plan
Retry-After: 0503 onconversations.listretries then returns Httpchat.postMessagesucceedsinternal_errorthen success on sendchannel_not_found/invalid_authstill fail on the first attempt