Repository navigation
fix(explorer): the whole row drags, the arrow stays, and the box starts from empty space (#320) - #321
Merged
Merged
Conversation
…ts from empty space (#320) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #320.
What
In the Explorer's list:
grabbing, set byinternalFileDrag.ts).Why
Owner, 2026-10-07: "when you left click drag an item dont switch the cursor to the hand, keep it the normal cursor. also its not possible to pick up items unless you left click drag when hovering over the file name. the whole row should let me left click drag. instead now it does the highlight drag thing to create a box of things to highlight. that drag should only be from empty spaces either under or beside the file row".
Causes:
internalFileDrag.tsinjectedcursor: grabbing !importantfor the whole page while carrying.BrowseList's pointerdown treated everything right of the name (onRowOwnPart) as blank space, started the sweep there and switched the row'sdraggableoff for the press (Drag-select rectangle in Explorer, and Explorer rows sized like the project tree #257's rule).minmax(160px, 1fr)), so there was no empty space next to them.Decisions
--browse-name-max(440px; Large 520px; search's Path to 560/640px) instead of the rest of the width, a row iswidth: fit-content(its hover and selection band ends with its last column), and a 32px--browse-gutteron the right is always blank, so even a narrow list, or one whose rows fill the height, has somewhere to start a box. The header uses the same grid and gutter, so the labels stay over their columns. Its last cell's box still runs on to the header's right edge, so the 2026-10-04 rule ("no strip of header a hover cannot fill") holds.Gates
npm run typecheck: cleannpm run lint: 0 errors (7 existing warnings)npx vitest run: 2526 passed, 2 skipped. One run had a timing flake insrc/main/listingCache.test.ts(unrelated, main process), which then passed 3 of 3 alone and in the full rerunnpm run e2e:terminal: 18 of 18 passmarqueechecks fail on main's source (14 FAIL: no blank space beside the rows (0px), no box from beside, no item drag from the Size or Date cell, no label). Shots:marquee-beside.png,row-drag-size.png,column-header-hover.pngPatch bump 0.92.1 to 0.92.2. CLAUDE.md gains the rule under the sweep section.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t