Repository navigation
fix(settings): every switch is the core's switch (#318) - #319
Merged
Merged
Conversation
The Win+E row drew its own switch (accent track, white knob), as did the phone server dialog and the player menu's toggles, beside the core's Switch everywhere else. They now use the core's Switch (or its SWITCH_ON / SWITCH_KNOB_ON at a menu's size), so once the core bump lands (PrismTerminal #139, core 0.26.0) every switch wears the style's accent with the ink chosen for it. A unit test refuses any role="switch" outside the core; settingsLook holds every Explorer switch to one look. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #318.
Owner, 2026-10-07: "toggles differ in look i like the teal with black not the green and white", then "yes option 1 but it should depend on the theme so only teal on the teal theme".
Why the Win+E switch differed
settings/WinEShortcutRow.tsxdrew its own<button role="switch">withbg-[var(--p-accent)]and abg-whiteknob, a deliberate exception from #202. Every other settings switch is the core'sSwitch(prism-term-core/renderer/settings/fields). Two more switches drew their own: the phone server switch (PhoneDialog.tsx, accent and white, off--p-hover) and the player menu's toggles (PlayerMenu.tsx, accent and white).What changed
Switch(label and disabled kept).SWITCH_ON/SWITCH_KNOB_ONwhen on.settingsControls.test.ts: Win+E is no longer an accent exception; a new test refuses anyrole="switch"in a renderer.tsx(the core draws all of them).settingsLooke2e: on the Explorer page, in a dark and a light style, every on switch has one look (button and knob classes, computed track and knob colours), every off switch has one, and the Win+E switch has the core's markup (it is off and unavailable outside a packaged build, so it cannot be measured on).The look
This PR makes every switch the core's; the core decides how it looks. Today (core 0.25.0) an on switch is the neutral grey. With Maxaubert/PrismTerminal#139 (core 0.26.0, not merged yet) the core bump makes every on switch
--p-sel-bgwith an--p-on-accentknob, so teal with a dark knob only on a teal style, and the Win+E switch follows with no further change here.Gates
settingsLook(with the new checks): passnpm run e2e:terminal: all checks passedNot installed for hands-on testing: the visible change only arrives with the core bump.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t