Record the cross-section library by name in the run provenance - #17
Merged
Conversation
The two tally files' cross_sections field now reads the library directory and file name, the form the generators write from now on, so the two agree; data-manifest.sha256 follows, and the changelog carries the entry above the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provenance block of the committed neutron runs stored the absolute path of the ENDF/B-VIII.0 cross_sections.xml on the machine that ran them. It now records the library directory and file name only, in the two generators and in the two committed runs. No numbers change.