Repository navigation
build(scripts): lay out the disk image window and draw its disk icon - #82
Merged
Merged
Conversation
create-dmg sets the background, arrow and icon positions on a read and write image before converting it, so signing, notarizing and stapling keep their order. The version is pinned in the script and the workflow so an image made by hand matches the released one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: The disk image is now made with create-dmg 8.1.0 The mounted disk shows the app's icon on a drive. The release workflow installs the same pinned version; signing, notarizing and stapling run in the same order as before.
Follow-ups: A release workflow dry run from this branch, to confirm the notarized and stapled image passes
stapler validateandspctl.Closes #74