Repository navigation
Conversation
…ble rules Closes #1979 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bhirsz
force-pushed
the
feat/split-missing-variable-type-rules
branch
from
November 15, 2026 12:55
defa2a9 to
2dfd3ca
Compare
Lakitna
reviewed
Nov 16, 2026
Comment on lines
+13354
to
+13355
| Variables defined in keywords and tests are checked by the separate | ||
| ``missing-keyword-variable-type`` and ``missing-test-variable-type`` rules. |
Contributor
There was a problem hiding this comment.
Agent artifact without meaningful documentation value
Lakitna
reviewed
Nov 16, 2026
Comment on lines
+13618
to
+13619
| VAR ${local} value | ||
| ${result} = Some Keyword |
Contributor
There was a problem hiding this comment.
Should these be separate rules?
Contributor
There was a problem hiding this comment.
I'm personally leaning towards no right now. But if, at some point, types can be inferred from the keyword return value, this should maybe be split.
Lakitna
reviewed
Nov 16, 2026
Comment on lines
+67
to
+68
| Variables defined in keywords and tests are checked by the separate | ||
| ``missing-keyword-variable-type`` and ``missing-test-variable-type`` rules. |
Contributor
There was a problem hiding this comment.
More agent artifact without meaningful documentation value
Lakitna
reviewed
Nov 16, 2026
| 41 | | ||
| 42 | Keyword With Assignment | ||
| 43 | ${result} = Set Variable value | ||
| | ^^^^^^^^^^^ ANN05 |
Contributor
There was a problem hiding this comment.
Should the underline be ${result} or ${result} =
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1979
Summary
Splits
ANN01: missing-section-variable-typeso type annotation requirements can be enforced separately per context:missing-section-variable-type- now only checks variables in the*** Variables ***section.missing-keyword-variable-type(new) - checksVARstatements and assignments (${var} = Keyword) inside keywords.missing-test-variable-type(new) - checksVARstatements and assignments inside tests and tasks.New rules are disabled by default and require Robot Framework 7.3+, same as ANN01.
Behavior change
Users who enabled
missing-section-variable-typeto also cover keyword/test variables now need to additionally selectmissing-keyword-variable-typeand/ormissing-test-variable-type.Tests
docs/rules_list.mdregenerated.