Conversation
Owner
Markel15
commented
May 31, 2026
Markel15
commented
- The completed subtasks are now visible from the task edition screen
- Quality of life improvements
- Fixed some bugs related with floats and numeric habits
- Changes in the color palette to make it more compatible with Material Themes (especially for a future update that would include Material You theme compatibility)
My main goal was to make the task creation sheet increase the size for every line written until arriving a state of full screen. This is connected a little bit with the issue #1. Apparently there's no native possibility of adding that behavior with the material bottom sheet. I won't create an own component for that because I would need to maintain and adapt it for every update. I decided to go with this behavior of limited size, 4 lines for the title and 8 lines for the description.
This is applied to the checklist editor and soon to the task editor screen to show the completed subtasks.
Now, you will be able to see the completed subtasks from the task editor screen.
The completed subtask description color now matches the completed subtask's titles style. Reduced a little bit the calendar chip color alpha too if completed.
Fixed a bug that caused that a numeric habit not showing the floating numbers when editing the habit quantity. It only showed the integer value.
Fixed a lot of bugs related to the float manipulation.
Before this, the completion percentage was absolute, not for every day of the week. It used the maximum days completed to calculate the rate for each day, not every available day. This fix includes another solution, since the bug didn't take into account to calculate the starting day of the week. Imagine you created tha habit a Saturday, the code counted the Monday of that week, that was misleading.
The bug fixed a problem in which the program used 2 different measurings to calculate if the day was completed with the entries. The weekly averages now only takes into account from the exact day of the week it started, it doesn't count some days prior to the day of creation (only counted the days from the same creation week). New tests to fit with the new calculation methods. Delete a debug println line
All the important logic for this was made in the FlowViewModel.kt, primarily the tasks passed to the UI are filtered before passing them. The filter looks if the tasks are in a list of pending tasks to delete. Deleted deleteTask from the TaskViewModel.kt Added tests for this too.
Centralize the button composable to not repeat it. I don't think there's anything more worth noting, apart from the obvious simplification of the drawables too and import changes to match the new location of the AnimatedUndoFab.kt
Update tertiaryContainer to match material 3 color scheme. This is primarily for the future if in an upcoming update dynamic color theming is supported.
Right now It doesn't support Material You since there's no option to select, but this refactorization makes it easier to add it in the future. It is planned to add a configuration to offer some theming and more personalization with different colors in the future.
The new recommended nav bar from Material 3, handles better every height and I think is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.