Skip to content

MDEV-31554 Cursor protocol cuts off json boolean #5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grooverdan wants to merge 1 commit into
base: 10.11
Choose a base branch
from
+3 −6
Open

MDEV-31554 Cursor protocol cuts off json boolean #5287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions mysql-test/main/func_json.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ select json_array(1);
--disable_view_protocol
select json_array(1, "text", false, null);

#enable after fix MDEV-31554
--disable_cursor_protocol
select json_array_append('["a", "b"]', '$', FALSE);
--enable_cursor_protocol
--enable_view_protocol
select json_array_append('{"k1":1, "k2":["a", "b"]}', '$.k2', 2);
select json_array_append('["a", ["b", "c"], "d"]', '$[0]', 2);
Expand Down
6 changes: 3 additions & 3 deletions sql/item.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4631,10 +4631,10 @@ class Item_bool :public Item_int
{
public:
Item_bool(THD *thd, const char *str_arg, longlong i):
Item_int(thd, str_arg, i, 1) {}
Item_bool(THD *thd, bool i) :Item_int(thd, (longlong) i, 1) { }
Item_int(thd, str_arg, i, 5) {}
Item_bool(THD *thd, bool i) :Item_int(thd, (longlong) i, 5) { }
Item_bool(const char *str_arg, longlong i):
Item_int(str_arg, i, 1) {}
Item_int(str_arg, i, 5) {}
bool is_bool_literal() const override { return true; }
Item *neg_transformer(THD *thd) override;
const Type_handler *type_handler() const override
Expand Down