Repository navigation
fix(cot): contain ingest delivery failures before worker handoff - #2297
Merged
mbuckton merged 2 commits intoOct 15, 2026
Merged
Conversation
Exercise message, payload, destination and enqueue failures, completion, failure accounting and a successful later delivery without inline twin updates. Refs: MSG-416
Restore exception containment and failure accounting around payload extraction and enqueue while retaining completion in finally and asynchronous twin updates. Refs: MSG-416
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2291 moved CoT twin processing onto a worker but removed delivery-side exception containment. Payload-access or enqueue exceptions now escape sendMessage, causing the existing sendMessageExceptionStillCompletes regression in Jenkins #241.
Restore a narrow RuntimeException catch with existing failure accounting and logging. Completion remains in finally; the bounded queue and asynchronous worker remain unchanged. Add five regression cases covering message/payload/destination/enqueue errors, absent completion, accounting and successful subsequent delivery using valid CoT input.
This is a separate correction to development, independent of MSG-415 / TLS integration PR #2296.
Validation: Jenkins #241 proves the existing regression. New focused red/green validation is pending; this PR remains draft until checked. Whitespace checks and independent source review passed.
Refs: MSG-416
https://mapsmessaging.atlassian.net/browse/MSG-416