fix(web): hovering a commit marker opens its commit card again by Makisuo · Pull Request #2578 · MapleTechLabs/maple

Makisuo · 2026-11-14T00:01:41Z

Hovering a deploy marker on the service charts did nothing useful: the Foldkit port left the marker card as a TODO(marker-cards), so a label only had a native title tooltip with its first commit, and a grouped marker (+2) never showed the other commits.

Hovering a marker label now opens a card listing every commit first seen in that bucket: avatar, subject, author, age and short sha (up to 8, then "+N more"). On a chart too dense for labels, the dashes open it. The hovered label and dash take the active style.

kit/service-metrics/marker-card.ts: the card body and its HoverCard init. One card per page, shared by every chart.
markerShas looks up every commit in a group, not only the representative, so the extra rows resolve.
The marker layer now renders beside the chart instead of through its overlay input: Foldkit refuses event handlers nested in a submodel's view inputs. The plot box fills the wrapper (measured offset 0,0 on all four charts), so marker positions are unchanged.
Wired on the service Overview grid, the API tab's responses chart and the release detail grid. The infra correlation strips keep idle markers for now.
/lab/bench/service-detail-markers: the grid with a grouped deploy, to try it without sign-in.

Before / after

Before (production, native title tooltip, first commit only):

After (lab bench, hovering the +2 group):

Verification

Typecheck and oxlint -c .oxlintrc.effect.json clean on the touched files; ui:patterns:check OK.
Vitest: service-metrics, services/detail and releases suites pass (182), plus a new markers.test.ts for the commit lookups.
Lab bench in the browser: the card opens on the grouped label and lists all three commits.
Not yet tried on a real service page with live deploys; a preview:web deploy would cover that.

🤖 Generated with Claude Code

^{Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.}

The Foldkit port left the marker hover as a TODO, so a grouped marker ("+2") only showed its first label in a native title tooltip. Hovering a label (or a dash on a chart too dense for labels) now opens a card that lists every commit in the group: avatar, subject, author, age and sha. Every commit in a group is looked up, not only the representative. Wired on the service Overview grid, the API tab's responses chart and the release detail grid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Foldkit refuses event handlers nested in a submodel's view inputs, so the marker layer can no longer ride in the chart's `overlay` input. It now sits beside the chart in the same wrapper (the plot box fills it, so the geometry lines up unchanged). Adds /lab/bench/service-detail-markers, the grid with a grouped deploy to hover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

maple-review-bot · 2026-11-14T00:01:48Z

Maple review

🟢 Confidence 8/10 · likely safe to merge. The marker card is wired the way the existing commit card is, but its own open path and row rendering ship untested.
_{1 warning −1 · tests partial −1 · risk low}

Hovering a deploy marker now opens a card listing the commits first seen in that bucket, wired on the service Overview grid, the API responses chart and the release detail grid. The wiring follows the existing commit-card pattern; the gap is that the card's own behaviour is not pinned by a test.

markerCardBody renders a marker group's commits in a shared HoverCard
markersOverlay takes a page card and binds label or dash triggers to it
markerShas resolves every commit a card lists, capped at MARKER_CARD_COMMITS
The marker layer moves beside the chart on the grid, API tab and release grid

Findings

🟠 Warning · F1 · The marker card's open path and its rows have no test

tests · apps/web/src/page/kit/service-metrics/marker-card.ts:70-74

markers.test.ts pins only markerShas. Nothing exercises what this PR adds: markersOverlay handing triggerFor to a label or dash, the groupOf lookup that resolves a trigger to its group, or markerCardBody listing a merged group's commits with the +N more cap. The repository scene-tests hover cards of exactly this shape.

Add a scene test: hover a grid marker label, resolve `WaitHoverDelay` and `MountHoverCard`, then assert the card lists every commit of the merged group and stops at `MARKER_CARD_COMMITS` with `+N more`.

🤖 Prompt to fix this finding with an AI agent

Findings from an automated review of commit 6e97b754f3b87c7c9262cfbb474104c01dfd4c35. Verify each one against the current code before changing anything, fix only those that still apply, and keep each fix to the lines it names.

---

F1 · Warning · tests · apps/web/src/page/kit/service-metrics/marker-card.ts:70-74
The marker card's open path and its rows have no test
`markers.test.ts` pins only `markerShas`. Nothing exercises what this PR adds: `markersOverlay` handing `triggerFor` to a label or dash, the `groupOf` lookup that resolves a trigger to its group, or `markerCardBody` listing a merged group's commits with the `+N more` cap. The repository scene-tests hover cards of exactly this shape.
Suggested fix: Add a scene test: hover a grid marker label, resolve `WaitHoverDelay` and `MountHoverCard`, then assert the card lists every commit of the merged group and stops at `MARKER_CARD_COMMITS` with `+N more`.

_{6e97b75 · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.}

coderabbitai · 2026-11-14T00:02:16Z

Caution

Review failed

The pull request is closed.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

devin-ai-integration

Devin Review found 1 potential issue.

devin-ai-integration · 2026-11-14T00:02:48Z

overviewTabSteps

+						markersOverlay(h, markerLayout(markers, plot), plot, MARKER_LABEL_GAP, "all", {
+							...markerCardOf(model, inputs.timeZone),
+							scope: "markers-api-responses",
+						}),


🟡 API deploy cards lack commit details

Opening the API tab directly makes markerCardOf show unavailable details for deploys with resolvable SHAs. commitsStep runs only on the Overview tab, so those commits load only after visiting Overview.

Learn more

The API responses chart draws deploy markers from the service overview's release timeline, but the page loads commit details only through overviewTabSteps. A direct API-tab visit still fetches the service overview, while apiTabSteps never invokes the commit lookup. The new hover card reads model.commits, so each unresolved SHA gets an unavailable row rather than its subject and author.

Example: Visit /services/orders?tab=api with a deploy at noon and a connected VCS repository. Hovering its marker shows “Commit details unavailable”; visiting Overview and returning loads the commit and fills the card.

Recommended fix: Run commitsStep(context) on the API tab once overview data is available, preferably in a shared step used by both tabs. Keep the existing missing-SHA check to avoid duplicate requests.

Was this helpful? React with 👍 or 👎 to provide feedback.

maple-review-bot

1 inline note from Maple's review. The score and summary are in the review comment above.

maple-review-bot · 2026-11-14T00:04:33Z

+}
+
+/** The card's body for one marker group: a header, one row per commit, and the overflow count. */
+export const markerCardBody = <M>(


Warning
The marker card's open path and its rows have no test

_{F1 · Warning · tests}

markers.test.ts pins only markerShas. Nothing exercises what this PR adds: markersOverlay handing triggerFor to a label or dash, the groupOf lookup that resolves a trigger to its group, or markerCardBody listing a merged group's commits with the +N more cap. The repository scene-tests hover cards of exactly this shape.

Add a scene test: hover a grid marker label, resolve `WaitHoverDelay` and `MountHoverCard`, then assert the card lists every commit of the merged group and stops at `MARKER_CARD_COMMITS` with `+N more`.

🤖 Prompt to fix with an AI agent

In `apps/web/src/page/kit/service-metrics/marker-card.ts:70-74`: The marker card's open path and its rows have no test. `markers.test.ts` pins only `markerShas`. Nothing exercises what this PR adds: `markersOverlay` handing `triggerFor` to a label or dash, the `groupOf` lookup that resolves a trigger to its group, or `markerCardBody` listing a merged group's commits with the `+N more` cap. The repository scene-tests hover cards of exactly this shape. Suggested fix: Add a scene test: hover a grid marker label, resolve `WaitHoverDelay` and `MountHoverCard`, then assert the card lists every commit of the merged group and stops at `MARKER_CARD_COMMITS` with `+N more`. Verify the problem exists at that location before changing it, and keep the fix to those lines.

Makisuo and others added 2 commits November 14, 2026 00:56

Makisuo merged commit c7892d9 into main Nov 14, 2026
25 of 27 checks passed

Makisuo deleted the fix/marker-hover-card branch November 14, 2026 00:02

devin-ai-integration Bot reviewed Nov 14, 2026

View reviewed changes

maple-review-bot Bot reviewed Nov 14, 2026

View reviewed changes

Navigation Menu

Repository navigation

fix(web): hovering a commit marker opens its commit card again - #2578

fix(web): hovering a commit marker opens its commit card again#2578
Makisuo merged 2 commits into
mainfrom
fix/marker-hover-card

Makisuo commented Nov 14, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

maple-review-bot Bot commented Nov 14, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Nov 14, 2026 •

edited

Loading

Review failed

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

devin-ai-integration Bot Nov 14, 2026

Uh oh!

maple-review-bot Bot left a comment

Uh oh!

maple-review-bot Bot Nov 14, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Makisuo commented Nov 14, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before / after

Verification

Uh oh!

maple-review-bot Bot commented Nov 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Maple review

Findings

Uh oh!

coderabbitai Bot commented Nov 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Nov 14, 2026

Choose a reason for hiding this comment

Uh oh!

maple-review-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

maple-review-bot Bot Nov 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Makisuo commented Nov 14, 2026 •

edited by devin-ai-integration Bot

Loading

maple-review-bot Bot commented Nov 14, 2026 •

edited

Loading

coderabbitai Bot commented Nov 14, 2026 •

edited

Loading