Repository navigation
fix(alerts): quieter Inbox and a tidier Rules table - #2451
Conversation
- Kit: rightSheet over the Dialog Submodel (672px form size, scrolling body, sticky footer, slide dropped under reduced motion) with followUrl/isDismissed; page/kit/sheet-param holds the ?sheet= helpers (push to open, replace to close). - Sidebar group labels fold their rows (sidebarGroupToggle, aria-expanded), saved to localStorage; the group holding the current page and the collapsed rail always show every row. - Footer on-call pill from the schedules list's on_call_now and the session user: on call until the handoff, not on call, or hidden without schedules. Re-read at each handoff; a dot with a tooltip on the rail. - /lab/shell shows all three, with a demo form in the sheet.
- Sheet: opening pushes a history entry marked as this tab's; dismissing goes back past it, and only a deep link replaces the param. Kit renamed to sidePanelSheet, footer receives close; sheet-param tests sit beside it. - On-call pill: a shift past its end reads as unknown; reads again at the handoff, hourly while off call, on focus and visibility, and with backoff (60s doubling, capped) after a stale or failed answer, keeping the last good data. Schedule and override writes announce a re-read. - An org with no schedules is cached per org for a day and skips the request; a schedule write clears it. - "until" uses the viewer's time zone with a short zone name. - Sidebar: the collapsed rail renders plain labels (no tab stops); the group holding the current page can fold and keeps only that row. The pill uses aria-label on the rail instead of a title.
… side panel
- Each hub section has its own path (/alerts/rules, /alerts/uptime, /alerts/slos,
/alerts/silences, /alerts/maintenance, /alerts/on-call, /alerts/routing); /alerts
stays the Inbox. One page instance serves them all, so a section change reads
nothing it already has.
- Old /alerts?tab= links replace themselves with the section's path and keep
their other params ("oncall" and "settings" map to on-call and routing).
- The sidebar's Alerts row lists the sections when active and replaces the hub's
own section rail. Sub-item aria-current now follows the most specific match.
- New silence opens in a URL-held side panel (?sheet=silence) with a sticky
Cancel / Save footer; Back, Cancel, Escape and a save close it.
sidePanelSheet gains onSubmit so the panel is a form.
- The silence panel clears ?sheet= in the model as soon as it closes itself, so a clock tick before the URL change can't reopen it. It opens only on the Silences section, and a viewer who can't manage loses a linked ?sheet= once the grants load (replaced away). - A rule lives at /alerts/rules/<ruleId>; /alerts/<ruleId> (notifications, the apps) replaces itself with it, keeping its tab and window. The rule page and editor go back to Rules and their crumbs go through it. - Settings automation and setup health link to the new section paths. - The sidebar reveals the open section, every sub-item past the edge fades, on each route change; sub-rows are tighter, thin rules split the former groups, and the Inbox shows its unacknowledged count from the alert_incidents collection, read only while an alerts page is open. - One AlertsTab schema next to AlertsSection; the sheet commands answer with a clock read instead of a no-op message.
…size - A `scrim-panel` token (12% black, 24% in dark) with no blur sits beside a side panel, so the page it edits stays readable. Dialogs and other sheets keep `scrim`. - `sidePanelSheet` takes `size`: `compact` (28rem) for a few short fields, `form` (42rem, the default) or `wide`.
- The on-call pill is one 32px row of the footer list: a status dot and "On call until Mon 09:00" in the viewer's zone (the date instead of the weekday once the handoff is over six days out), or a muted "Not on call". The zone, date and schedules are its tooltip and accessible name. On the collapsed rail it is a calendar glyph badged with the dot. - Group chevrons show faintly at rest; the toggle is 28px tall. - A folded group holding the current page shows that page's parent row alone, highlighted, without its sub-items. - Hover is a neutral wash. When a sub-item is the current page only it is tinted; its parent keeps the medium weight on a plain background. - Sub-item rows are 28px on desktop and 36px in the mobile sheet. - /lab/shell gains Services and Logs pages, a far handoff and both panel sizes.
… the silence panel
- Each section's header has one primary action: New rule (split) on the Inbox
and Rules, New monitor, New SLO, New silence, New window, New schedule and
Add destination on their own sections. A section whose empty state already
offers it shows none until it has rows.
- The Alerts sub-list sets its groups apart with a 4px gap instead of rules,
and its rows take the kit's height again.
- The silence panel's Services, Environments and Tags are chips inputs that
suggest what the org's rules name (and the services Uptime listed); a typed
name can still be added. Its labels share one style.
- A picked end is on the viewer's clock and the field names the zone
("Ends, CET"); a scheduled row names its day once. The lab reads the
viewer's zone instead of UTC.
- The duration choice uses the larger segmented size.
- Rules toolbar: a fixed-width search keeps the four status chips on one line. The ribbon column gives its spare width to Routes, "Fired 30d" stays on one line, and a lone "No tag" group header is left out. - One headroom tone for the rules table and the Inbox: neutral unless under a tenth of the threshold is left (warning) or it is breached (error). The Inbox's bars are thinner and their threshold tick is neutral. - Inbox: Acknowledge and Unacknowledge are the same small outline button, an empty MTTR reads "n/a", the Anomalies toggle is left out when the window has no anomaly (and shows no zero count), and an ungrouped reading says "all services". - A scene test pins that a rule's row is one link to the rule with its actions menu beside it.
# Conflicts: # apps/web/src/shell/oncall.scene.test.ts # apps/web/src/shell/view-nav.ts
This comment has been minimized.
This comment has been minimized.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…of re-spelling it
This comment has been minimized.
This comment has been minimized.
|
F1 fixed in 109147b: the Inbox imports |
|
The import now points at the real export, but it's the wrong vocabulary, so F1 isn't fixed — it swapped one constant for another. // packages/backend/src/services/alerts/AlertRuleModel.ts:332
: (isGroupedPlan(plan) ? engineGroupKey : UNGROUPED_GROUP_KEY)so storage holds There's a second reason the branch can't fire: // view-inbox.ts:552 — row.groupLabel is "…__total__…" or null, never "all"
row.groupLabel === ENGINE_UNGROUPED_GROUP_KEY ? "all services" : row.groupLabelWhat would settle it, and the shape of the fix: read |
…tures on the stored key
|
You're right, thanks. Fixed in 26c44d4: the "all services" branch is gone (it could never fire: an ungrouped state row is |
This comment has been minimized.
This comment has been minimized.
|
F2 fixed in 48df8a0: |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # apps/web/src/shell/command.ts # apps/web/src/shell/flags.ts
# Conflicts: # apps/web/src/page/settings/audit-log/view-detail.ts # apps/web/src/route/search.ts
surface-sunken sits under 1% from the light sidebar's grey. Rows now hover at half the selected tint (bg-sidebar-accent/50): visible in light, unchanged in dark.
This comment has been minimized.
This comment has been minimized.
Preview testTested on the combined preview of the whole stack (#2466, app-pr-2466.maple.dev) by a separate test agent in a real browser: happy paths, break attempts, light and dark, and a 390x844 viewport. No uncaught page errors. Passed: the Rules toolbar keeps its four chips on one line at 1440 and 1280; a click on any cell opens the rule and the actions menu opens without navigating; chips and search filter, with "No rules match these filters" when nothing matches; a quiet Inbox reads "Nothing firing · quiet for 24h+" with "MTTR n/a" and no Anomalies toggle; Acknowledge and Unacknowledge flip the heading to "1 firing · 1 acknowledged"; a breached rule's headroom bar is red with "over threshold". Fixed in this push: merging the parent's first-run change left the Inbox filters without Not covered on the preview: the neutral and under-10% headroom tones (no rule sat below its threshold with data) and an ungrouped rule's reading. Both are covered by unit tests. Traces (preview environment
|
|
F3: fixed in |
This comment has been minimized.
This comment has been minimized.
…n tab finds the first one
…read within the hour whoever holds it
# Conflicts: # apps/web/src/shell/view-nav.ts
This comment has been minimized.
This comment has been minimized.
# Conflicts: # apps/web/src/shell/message.ts # apps/web/src/shell/model.ts # apps/web/src/shell/oncall.scene.test.ts # apps/web/src/shell/update.ts # apps/web/src/shell/view-nav.ts # packages/views/src/ui/sheet.ts
This comment has been minimized.
This comment has been minimized.
# Conflicts: # apps/web/src/page/alerts/hub/hub.scene.test.ts
Maple review🟢 Confidence 10/10 · safe to merge. Only real behavior change is Polish for the alerting Inbox and Rules table: one
|
Stacked on #2426. Polish for the Inbox and Rules screens, from a design critique of the alerting pages.
What changed
packages/web-data, so both pages agree). Bars are thinner and the threshold tick is neutral.__total__(incident titles now use the same helper as the incident timeline). The test fixtures used the query engine's"all", which storage never holds, so the lab showed an "all" line that real data never has; they now carry the stored key.The rule condition text in the table and incident header is unchanged here: it will reuse the rule editor's sentence builder once #2425 lands.
Before / after
Phone:
(The screenshots predate the merge of #2419's sidebar changes; the page content is the same.)
Verification
bunx vitest run src/page/alerts src/shell src/route src/lab src/page/kitand rootsrc/*.test.ts: 872 tests pass;packages/web-dataalerts tests 161 pass.oxlint -c .oxlintrc.effect.jsonclean on changed files;ui:patterns:checkpasses.Not verified against live data (the lab uses fixtures).
🤖 Generated with Claude Code