Skip to content

chore(web): remove dead front-end code left by the Foldkit migration - #2449

Merged
Makisuo merged 17 commits into
chore/audit-docs-leftoversfrom
chore/audit-frontend-dead-code
Nov 10, 2026
Merged

Makisuo merged 17 commits into
chore/audit-docs-leftoversfrom
chore/audit-frontend-dead-code

Merge branch 'chore/audit-docs-leftovers' into chore/audit-frontend-d…

8d3f920
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 10, 2026 in 2m 24s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Dead-code deletion only: every removed export name has no reference at the head SHA, and no live caller changed.
no findings · tests not needed · risk medium

Removes unreferenced front-end code across apps/web, packages/ui and packages/web-data, plus a stale Vite flag, and adds three missing define keys. I grepped every removed name at the head commit and found no remaining user, so it is safe to merge.

  • Removes ~70 unreferenced *.styles.ts constants and dead helpers from packages/ui
  • Drops toWhereClause, identityFromKey and factoryLinks; tests now call the live helpers instead
  • vite.config.ts define list gains VITE_CLERK_SIGN_IN_URL, VITE_CLERK_SIGN_UP_URL and VITE_MCP_URL
  • Retires the VITE_MAPLE_CAPTURE flag and its requireConsent branch in platform/telemetry.ts

Before merge

  • Manual · Confirm VITE_CLERK_SIGN_IN_URL, VITE_CLERK_SIGN_UP_URL and VITE_MCP_URL are set in the prd and dev deploy env, since they are now baked into the bundle
What was checked
  • Grepped all 88 removed export names at head 8d3f920: no reference outside the deleted files and their tests
  • No @maple/web-data bare or /collections importer, and no main/types field, so the dropped exports break nothing
  • packages/widgets tracks no .tsx file, so narrowing tsconfig.include type-checks the same set

8d3f920 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.