Skip to content

chore(docs): drop references to things the stack removed - #2448

Merged
Makisuo merged 18 commits into
fix/audit-librariesfrom
chore/audit-docs-leftovers
Nov 10, 2026
Merged

Makisuo merged 18 commits into
fix/audit-librariesfrom
chore/audit-docs-leftovers

Conversation

@Makisuo

@Makisuo Makisuo commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #2447. Part of the audit stack that starts at #2434.

Small follow-ups the earlier layers left in files they did not own.

  • MAPLE_DB_URL is gone. The module that turned it into a PGlite data directory was removed in fix: audit first pass (rollup hour bounds, apdex errors, fetch capture, Tinybird 429 retry) #2434, the Env field had no reader, and docs/persistence.md and .env.example still described a persistent local PGlite. Tests and evals use PGlite in memory and need no setting.
  • CLAUDE.md and AGENTS.md named SubagentHost, which does not exist in the source. The review fan-out uses Subagent from @yielded/agent/subagent.
  • Comments and docs that pointed at things removed lower in the stack: nginx.conf, the compose build of the scraper image, the renamedFrom shims, alert-templates/, and a generated route tree the formatter config still mentioned.
  • .env.example said Llm.ts lives in apps/api. It is in apps/ai.

Verification

  • packages/backend typecheck is clean after removing the Env field. Lint is clean on the two code files.

Deliberately untouched

  • Root app.json, TODO.md, the tracked .context/ directory, doctor.config.json and the react-doctor skills. These look like leftovers but are yours to decide.
  • lib/semconv, which nothing imports.
  • docs/browser-sdk.md, an older copy of the landing docs page.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

- MAPLE_DB_URL: the PGlite data-dir path it configured is gone, nothing read
  the Env field, and persistence.md and .env.example still described it.
- CLAUDE.md and AGENTS.md named SubagentHost, which is not in the source;
  the review fan-out uses Subagent from @yielded/agent/subagent.
- Comments and docs that pointed at nginx.conf, the compose build, the
  renamedFrom shims, alert-templates and a generated route tree.
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b257c12d-3eb2-4883-a15b-fbced751459d
Commits

Reviewing files that changed from the base of the PR and between b394a3d and 2b4c920.

Files selected for processing: 9

  • .env.example
  • .oxfmtrc.jsonc
  • AGENTS.md
  • CLAUDE.md
  • apps/scraper/Dockerfile
  • apps/web/src/document-headers.ts
  • docs/persistence.md
  • docs/product-events-dashboard-parity.md
  • packages/backend/src/platform/Env.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

maple-review-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Comment and doc-string cleanup plus one dead Env field; a full-tree grep confirms nothing reads MAPLE_DB_URL at the head.
no findings · tests not needed · risk low

Removes the reader-less MAPLE_DB_URL from Env and .env.example and corrects stale comments (scraper Dockerfile, nginx.conf, routeTree.gen.ts, Llm.ts path). Every claim holds against the head tree; safe to merge.

Before merge

2b4c920 · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@Makisuo
Makisuo merged commit e879420 into main Nov 10, 2026
42 checks passed
@maple-review-bot

Copy link
Copy Markdown

Merged with 1 step from "Before merge" still open. If it is done, tick it on the review comment; if not, now is the time.

  • Infra · Check every environment has what this config now expects

@Makisuo
Makisuo deleted the chore/audit-docs-leftovers branch November 10, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant