Repository navigation
fix(web): wire API reachability, lenient string search params, sidebar state, chart and cache memoization - #2445
Merged
Maple Review Bot / Maple / review
succeeded
Nov 10, 2026 in 3m 46s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Mechanical, well-tested changes: each new behavior has a test and the cache memoization is a pure function of the rows array.
no findings · tests covered · risk medium
Wires the API reachability clock the HTTP client writes into the warehouse layer, makes string search params accept an unquoted number/boolean/null, reads the sidebar cookie at boot, and memoizes bar-chart rows and cache use times. Safe to merge.
withRequestTimeoutmarks an origin reachable on any response, unreachable on transport failuresStringParamaccepts number, boolean and null and prints them back as textshell.flagsreadssidebar_stateso a collapsed sidebar stays collapsedrowsCacheandcollectUnusedkeep chart rows and prune cache use times
Before merge
- Manual · Check the collapsed sidebar and a hand-written
?userId=12345link in thepreview:webdeploy; nothing was run in a browser
What was checked
LenientString's forbidden encode never runs: the string member encodes first, pinned by thehrefOfround trip (route.test.ts:58)bucketBarSeries/seriesDefinitionsOfdepend on the rows array alone and the cache is a WeakMap (chart-spec.ts:508)- Timeouts still mark the origin unreachable through the
tapErrorTransportErrorbranch
7f3f5b0 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading