Skip to content

feat(audit-log): day headings, a red edge on refusals, quieter reads - #2424

Merged
Makisuo merged 20 commits into
mainfrom
audit-log-ui/c-rows-layout
Nov 10, 2026
Merged

Makisuo merged 20 commits into
mainfrom
audit-log-ui/c-rows-layout

Merge branch 'main' into audit-log-ui/c-rows-layout

33f2691
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 10, 2026 in 1m 25s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Contained UI change; the new heading and day-label behaviour is pinned by a scene test plus the moved DST and zone-midnight cases.
no findings · tests covered · risk low

Groups audit log rows under day headings, gives denied rows a red left edge, mutes allowed reads in the All view only, and shares dayKey/dayLabel from page/kit. Safe to merge.

  • withDayHeadings renders a Today/Yesterday/date heading wherever the viewer's local day changes
  • dayKey and dayLabel move to page/kit/day-label, used by the users detail too
  • isQuietAccess mutes allowed read, tool, SQL and API actions, gated on the All view
  • Denied rows carry a border-l-severity-error edge; the Source column shows from @xl
What was checked
  • Muting needs auditLogKindOf(...) === "all" (view.ts:420, 476), so the Data access view keeps full contrast
  • Row pl-3.5 plus the 2px border equals the header's px-4, and at @xl (576px) the row leaves 116px for the truncating action cell, so nothing overflows
  • AUDIT_ACCESS_ACTION_SUFFIXES now lives in @maple/domain/audit-actions; the backend filter and the lab read the same list, so server and view agree

33f2691 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.