Repository navigation
feat(audit-log): split changes from data access, add resource/action/lookup filters - #2422
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Nov 10, 2026 in 2m 15s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Kind SQL, filter parsing, lookup refusal and the custom-range round-trip are pinned by tests; only the browser-level interplay of the new selects is unexercised.
no findings · tests covered · risk medium
Splits the audit log into Changes / Data access / All and adds resource-type, action, affected-user, resource, request and lookup filters, plus a working custom range. The server keeps all as the API default, so no existing client changes behavior.
GET /v2/audit_loggainedkind=changes|access|all, defaulting toallAuditLogService.listpushes the access-action exclusion into the query, keeping denied reads- The tab opens on Changes, with resource/action/affected filters and an ID lookup
- Custom range… opens the shared calendar and writes UTC instants into the URL
What was checked
changescompiles to NOT(endsWith…) OR Outcome='denied', pinned by a SQL test (AuditLogService.test.ts:536)CancellationReviewServicepassesexcludeActionSuffixeswithoutactionKind, so its SQL is unchanged (AuditLogService.ts:196)- The affected-user select renders only once members load; a chip covers the Clerk-less case (
view.ts:539), and every lookup param exists onV2AuditLogQuery
9833c48 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading