Repository navigation
feat(query-builder): condition builder for the where clause - #2420
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Nov 10, 2026 in 44s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Test-only delta on the operator table, pinned against Operator.literals and the engine's group warnings; no production code changed.
no findings · tests covered · risk low
This head adds the two missing pins to the condition builder's operator table: WHERE_OPERATORS is held to the grammar's operator literals, and whereKeyMatchesAnyOf to how the engine actually lowers OR groups. No production behavior changes.
where-key-rules.test.tssortsWHERE_OPERATORSagainstOperator.literalsso a grammar operator can't be missed- Twelve cases run a real OR-group clause through
buildTimeseriesQuerySpecper source and key
Fixed since the last review
- ✅
F15 ·WHERE_OPERATORSis a hand copy of the domainOperatorliterals - ✅
F16 · No case exerciseswhereKeyMatchesAnyOf, so its OR-group claim is unpinned
What was checked
Operator.literalsis a real runtime value: repo precedent atpackages/domain/src/audit-actions.ts:79- Product-events groups warn because
orGroupsis false for that source (model.ts:1448), matching the rule'sfalse applyOrGroupwarns forservice.namegroups (named field →map === undefined,model.ts:456), so the dimension cases are not vacuous
1ac178f · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading