Repository navigation
Maple Review Bot / Maple / review
succeeded
Nov 10, 2026 in 1m 33s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. The four files changed since the last pass add pure helpers and nav rendering, each pinned by scene tests with an explicit now, so nothing depends on wall-clock time.
no findings · tests covered · risk medium
The final pass on the shell rework: oncall.ts decides the pill's state, copy and re-read schedule, and view-nav.ts folds labelled groups while keeping the current row. Both are self-contained and tested; safe to merge.
onCallStatusOfnames the pill from the soonest-ending live shift, hides a staleUnknownscheduleAfterAnswerre-reads at the handoff or hourly, backing off a passed handoffnavRowfolds to the current sub-item under its section row when its group is foldednavGroupFoldkeeps the collapsed rail unfolded, with plain labels as no tab stops
What was checked
formatUntilgets a validated IANA zone:readEffectiveTimeZonerejects an unknown stored zone (platform/time-zone.ts:37), soIntl.DateTimeFormatcannot throw in renderpartitionSubItemskeeps a sub-item matching the current path, so a folded group still shows the current sub-item when its surface is absent (nav.ts:245)- The new scene tests pass
onCallNowMsandHANDOFFexplicitly, so the pill's states do not decay with the calendar
7360717 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading