Skip to content

fix(web): count open anomalies apart from firing incidents on the overview banner - #2360

Merged
Makisuo merged 3 commits into
mainfrom
fix/overview-anomalies-not-incidents
Nov 7, 2026
Merged

Makisuo merged 3 commits into
mainfrom
fix/overview-anomalies-not-incidents

fix(web): firing incidents and open anomalies side by side in one ale…

eaab70e
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 7, 2026 in 57s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge. The anomaly split is correct and pinned by a scene test; the all-clear assertion at overview.scene.test.ts:246 still cannot fail.
2 notes · tests partial −1 · risk medium

The Overview banner now separates anomaly-rule incidents (amber "Open") from firing incidents (red "Firing now"), drawn as one slim strip that disappears when nothing is open. The count split is correct; the two findings already open on this pull request still stand.

  • heroCountsOf counts anomaly-rule incidents apart from firing ones
  • alertFiringHero returns no element when all clear, dropping the All clear card
  • New /lab/anomaly-alerts?state=overview-banner state shows each strip case

Still open from earlier reviews

What was checked
  • signalType survives the sync: rowsToAlertIncidentDocuments to subscription.ts:35
  • AlertSignalType (packages/domain/src/http/alerts.ts:47) includes anomaly, so real rows split
  • text-severity-warn and border-severity-warn-a3 exist: packages/ui/src/styles/tokens.css:140

eaab70e · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.