Repository navigation
fix(web): count open anomalies apart from firing incidents on the overview banner - #2360
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Nov 7, 2026 in 57s
Confidence 9/10 · No issues found
🟢 Confidence 9/10 · safe to merge. The anomaly split is correct and pinned by a scene test; the all-clear assertion at overview.scene.test.ts:246 still cannot fail.
2 notes · tests partial −1 · risk medium
The Overview banner now separates anomaly-rule incidents (amber "Open") from firing incidents (red "Firing now"), drawn as one slim strip that disappears when nothing is open. The count split is correct; the two findings already open on this pull request still stand.
heroCountsOfcounts anomaly-rule incidents apart from firing onesalertFiringHeroreturns no element when all clear, dropping the All clear card- New
/lab/anomaly-alerts?state=overview-bannerstate shows each strip case
Still open from earlier reviews
- 🔵 Note · F1 ·
bg-severity-warn/[0.04]breaks the tone alpha steps indocs/design-rules.md·apps/web/src/page/overview/view-hero.ts:85 - 🔵 Note · F2 ·
without live alertsbanner test cannot fail after the strip change ·apps/web/src/page/overview/overview.scene.test.ts:246
What was checked
signalTypesurvives the sync:rowsToAlertIncidentDocumentstosubscription.ts:35AlertSignalType(packages/domain/src/http/alerts.ts:47) includesanomaly, so real rows splittext-severity-warnandborder-severity-warn-a3exist:packages/ui/src/styles/tokens.css:140
eaab70e · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading