Repository navigation
feat(alerts): on-call schedules in the dashboard: who is on call, a calendar, overrides, and paging people - #2307
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge
1 note
Findings
🔵 Note · F23 · The tick's Refresh mode is not pinned; the scene test passes with Supersede
tests · apps/web/src/page/alerts/incident/update.ts:542-543
The point of this head commit is that the minute poll re-reads the activity with Refresh, so a slow read is not superseded. incident-escalation.scene.test.ts:98 only asserts a fetch is issued, which Supersede also does, so a regression back to superseding on every tick keeps the suite green.
Assert the tick's re-read keeps the slot's key: after `TickedClock`, expect `model.activity.key` to carry no generation, and a `CompletedFetchActivity` for that key to land.
Production impact
Open errors in the changed files (2)
| Issue | Service | Occurrences | File |
|---|---|---|---|
| @maple/mcp/errors/McpQueryError (5 issues) | maple-chat | 33 | apps/web/src/page/registry.ts |
| @maple/mcp/errors/McpQueryError (5 issues) | maple-ai | 15 | apps/web/src/page/registry.ts |
After this merges, Maple checks whether they stop.
e0f7481 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Annotations
Check notice on line 543 in apps/web/src/page/alerts/incident/update.ts
maple-review-bot / Maple / review
tests: The tick's `Refresh` mode is not pinned; the scene test passes with `Supersede`
The point of this head commit is that the minute poll re-reads the activity with `Refresh`, so a slow read is not superseded. `incident-escalation.scene.test.ts:98` only asserts a fetch is issued, which `Supersede` also does, so a regression back to superseding on every tick keeps the suite green.