Skip to content

feat(slos): latency ladder counters on the service overview rollups - #2294

Merged
Makisuo merged 6 commits into
feat/slo-modelfrom
feat/slo-latency-ladder
Nov 6, 2026
Merged

Makisuo merged 6 commits into
feat/slo-modelfrom
feat/slo-latency-ladder

Merge branch 'feat/slo-model' into feat/slo-latency-ladder

79897a7
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 6, 2026 in 1m 12s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Column order, frozen DDL and generated schema all agree, and the ladder, its zero coverage on old buckets and the v50 to v51 edge are each pinned by a test.
no findings · tests covered · risk high

Adds nine sampling-weighted SLO latency ladder counters to both service overview rollups, in migration 0059, the Tinybird views (deployed by ALTER) and the v51 local schema, with tests for the view math, the zero coverage of pre-0059 buckets and the chDB edge. Safe to merge.

  • Migration 0059 adds the eight rungs plus EstimatedLadderSpanCount and recreates both overview views
  • SLO_LATENCY_LADDER_SQL derives the rung SQL from SLO_LATENCY_THRESHOLDS_MS; both views deploy by alter
  • Local store goes to v51 with addColumns and view drops in the step, plus a v51 snapshot

Before merge

What was checked
  • local-schema-v51.sql is byte-identical to local-schema.sql at the head (diff, no output)
  • Rung order matches across the 0059 ALTER, sloLatencyLadderColumns and the step's addColumns
  • openapi.json, named as changed since 03d6a29, is not in this PR's file list

79897a7 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.