Skip to content

feat(kit): effect-orm pull — definitions from an existing ClickHouse database - #35

Merged
Makisuo merged 3 commits into
mainfrom
feat/pull
Oct 15, 2026
Merged

Makisuo merged 3 commits into
mainfrom
feat/pull

fix(pull): go on without skipping indexes a read-only user cannot read

355317d
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review completed Oct 15, 2026 in 1m 56s

Confidence 8/10 · 1 issue to address

🟢 Confidence 8/10 · likely safe to merge
The delta is contained, but F1 (a non-plain skipping-index name) is still live in introspect.ts/codegen.ts at this head.
quality 90/100 · 1 warning · tests covered · risk medium

This head lets pull continue when a read-only user cannot read system.data_skipping_indices (no indexes, a note saying so), and has verify read the catalog through the shared helper. Neither commit adds a new defect, but the feature still carries the open F1 and should not merge until it is fixed.

  • readClickHouseCatalog takes optionalIndexes; pull continues with no indexes and a note
  • verify reads the catalog strictly through the same helper
  • introspectClickHouse swallows an unreadable index query instead of failing

Still open from earlier reviews

  • 🟠 Warning · F1 · An index name that is not a plain identifier makes the pulled module fail generate --baseline · src/kit/codegen.ts:227
What was checked
  • readClickHouseCatalog has no other caller in src/ (grep), so the new parameter breaks none
  • declaredKeys and unwrapTuple unwrap both the expected and the actual key, so the comparison adds no drift
  • The unread-index path is pinned both ways by pull.test.ts:73 and pull.test.ts:76

355317d · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.