Skip to content

Ogbench #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
helenlu66 wants to merge 2 commits into from
Closed

Ogbench #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb08111
added ogbench as a submodule
helenlu66 Apr 30, 2026
0d26531
fixed some D2 mazes
helenlu66 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "ogbench"]
path = ogbench
url = ./ogbench
21 changes: 21 additions & 0 deletions .vscode/launch.json
View file
Open in desktop
Copy link
Copy Markdown
Member

@pranavguru pranavguru Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this file need to be pushed to the repo? Seems like a developer config file

Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"name": "Python Debugger: Current File",
"type": "debugpy",
"request": "launch",
"program": "${file}",
"console": "integratedTerminal",
// add python paths
"env": {
"PYTHONPATH": "${workspaceFolder}/ogbench:${workspaceFolder}/ogbench/ogbench:${workspaceFolder}/ogbench/ogbench/procgen"
}

},

]
}
1 change: 1 addition & 0 deletions ogbench
Open in desktop
Copy link
Copy Markdown
Member

@pranavguru pranavguru Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submodule is unclonable. Two independent issues:

  1. .gitmodules declares url = ./ogbench. Git resolves relative submodule URLs against the parent repo's origin, producing https://github.com/ManifoldRG/MultiNet-v2.0.git/ogbench, which doesn't exist. Repro:
$ git submodule update --init --recursive
fatal: repository 'https://github.com/ManifoldRG/MultiNet-v2.0.git/ogbench/' not found

  1. Fix: replace with an absolute URL.

  2. The pinned SHA d7509418e7a2243ebea3c5fc081ed57557e89719 is not reachable on canonical seohongpark/ogbench:

$ git ls-remote https://github.com/seohongpark/ogbench.git | grep d7509418
 (no output)
  1. So even after fixing the URL, the submodule won't resolve unless we point at the fork that actually contains those commits

Before merging, we need to:

  • Confirm where SHA d7509418e7… actually lives. If it's on a personal fork, push it to a ManifoldRG/ogbench fork instead so the pin doesn't depend on a personal account.
  • Update .gitmodules to the absolute URL of that fork.
  • Open an upstream PR (or a long-running fork branch) for the OGBench-internal D2 maze fixes, so we have a path to eventually re-sync with seohongpark/ogbench and not maintain a permanent fork.

Submodule ogbench added at d75094