Fixes issues for building the core standalone on macOS brought up in issue 1228#1249
Open
thoellt wants to merge 3 commits into
Open
Fixes issues for building the core standalone on macOS brought up in issue 1228#1249thoellt wants to merge 3 commits into
thoellt wants to merge 3 commits into
Conversation
This enables objective-c compilation on macOS for creating compatible precompiled headers for the .mm them helper file
This bundles the MV_Public and qtadvanceddocking dylibs with the app bundle on postbuild rather than install. This allows for easier debug/run out of the box. Addition of the libraries during the install step was also flaky for me, so moving this should also improve when running from the installed bundle. Note: Setting the working exe/directory (ll. 465-468) does not seem to have any effect for me. My understanding is that XCode cannot handle this while the build is not there. So if one wants to run from the install folder this still needs to be done manually after building
thoellt
changed the title
The previous solution did not properly solve the version numbering of rpath and embedded library for advanced docking. this creates a symlink using the SONAME used for the rpath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PCH problem is addressed here by enabling Objective C(++) compilation for macOS, rather than turning of precompiled headers.
Running the app from the debugger immediately crashed for me because the built libraries (MV_Public and qtadvanceddocking) were not embedded into the app bundle. I moved this step from install to post build to make sure it happens and by doing it as post build the libraries will already be there in build-tree, rather than only in install.
I have tested this with Xcode projects and makefiles (in VS Code) as target.