Repository navigation
Fix red main: resolve frontend lint errors breaking Azure and Netlify builds (PR 14 follow-up) - #16
Conversation
Wire PackageSubcircuitModal and AIVisionIntakeModal into App, dedupe ai-intake listeners, repair Sidebar accordion title JSX, and fix InteractiveProbeTooltip hook deps and imports.
✅ Deploy Preview for digisim ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…hout token Netlify deploy previews fail on every PR because the repo root has no build config (frontend/ is the CRA app). Azure Static Web Apps fails because AZURE_STATIC_WEB_APPS_API_TOKEN is not configured; skip the upload instead of failing the check until the secret exists.
typescript@5.9.3 conflicts with react-scripts@5.0.1 peerOptional ^3||^4, so plain npm install/npm ci (Netlify, Azure Oryx) die with ERESOLVE while only the GitHub workflow survived via its --legacy-peer-deps fallback. Verified: clean npm ci fails without this file, succeeds with it.
|
Follow-up fixes pushed on top of the lint fix, all checks now green (6 passed, 1 skipped): 837efe9 added netlify.toml (repo root had no build config, so Netlify previews had nothing to build) and skip_deploy_on_missing_secrets for the Azure step (AZURE_STATIC_WEB_APPS_API_TOKEN secret is not configured); 0a01f1f added frontend/.npmrc with legacy-peer-deps=true. Root cause found via clean-room repro: typescript@5.9.3 vs react-scripts@5.0.1 peerOptional ^3||^4 makes stock npm install/npm ci die with ERESOLVE (verified clean npm ci fails without .npmrc, passes with it) - this broke Netlify and Azure Oryx installs while only the GitHub workflow survived via its --legacy-peer-deps fallback. Local evidence: tsc clean, CI=true build compiles, 174/174 tests pass (30 suites). Pipeline review/document agent steps were skipped (pi 429); local suite stands as evidence. Not merging - awaiting review. |
Fix-forward for red main after PR #14 (subcircuit hierarchy) merged with failing checks.
What this fixes (cherry-picked ready fix):
frontend/src/App.tsx: wiresPackageSubcircuitModalandAIVisionIntakeModalinto App, dedupesai-intakelisteners (11 unused-var warnings gone)frontend/src/components/AIVisionIntakeModal.tsx: import reordered to top (import/firsterror gone)frontend/src/components/Sidebar.tsx: accordion title JSX template-string fix (no-template-curly-in-stringwarning gone)frontend/src/components/canvas/InteractiveProbeTooltip.tsx: hook deps + unused imports fixed (exhaustive-deps+ unused-var warnings gone)Evidence (all local, single-run flags):
tsc --noEmit: cleanCI=true npm run build: Compiled successfullyCI=true npm test -- --watchAll=false: 30 suites, 174/174 tests passProcess note: the no-mistakes pipeline could not run its review/document/test agent steps - the pi/Antigravity backend is quota-exhausted (HTTP 429 until 2026-09-23T04:00:00Z) on every agent step, so those steps were skipped and the local suite above stands as evidence. Pushed manually per captain/firstmate decision; not merged.