docs(selfhost): show how to generate VAPID keys on a Docker install - #344
Open
HearthCore wants to merge 1 commit into
Open
HearthCore wants to merge 1 commit into
HearthCore wants to merge 1 commit into
Conversation
The only documented command, pnpm --filter @deft/api exec web-push generate-vapid-keys, needs a source checkout with pnpm. Docker operators have neither on the host; web-push already ships in the app image. Also list the VAPID variables in the self-hosting environment table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The only documented way to create VAPID keys is
pnpm --filter @deft/api exec web-push generate-vapid-keys, which needs a source checkout with pnpm. Docker operators have neither on the host, butweb-pushalready ships in the app image. This adds thedocker compose execvariant to.env.example, states themailto:/https://subject rule thatselfhost:doctorenforces, and lists the three VAPID variables in the self-hosting environment table.Type
Test plan
git diff --checkis clean./app/apps/api/node_modules/.bin/web-pushis present andweb-pushexportsgenerateVAPIDKeys. Keys generated in the container passselfhost:doctor([OK] Browser notifications).Related issues
None found (searched open and closed issues and PRs).