fix(docker): stop pinning a stale release version in source builds - #343
Open
HearthCore wants to merge 1 commit into
Open
HearthCore wants to merge 1 commit into
HearthCore wants to merge 1 commit into
Conversation
The Dockerfile defaulted DEFT_RELEASE_VERSION to 0.3.0-preview.14. Docker source builds (docker compose build) never pass the arg, so /health, the Agent Channel handshake and the Hermes integration bundle URL reported preview.14 on a preview.15 checkout. The env default beat the in-code fallback in agent-channel.ts, which release prep already keeps current. Leave the arg empty so the in-code fallback applies; the release workflow still passes the exact version. A release-workflow test guards against the default coming back.
Author
|
Built this branch as an image (
Release images are unaffected, and source builds report the checked-out version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
DockerfiledefaultsARG DEFT_RELEASE_VERSION=0.3.0-preview.14in both stages.docker compose buildfrom a source checkout never passes that arg, so a preview.15 checkout reportsrelease: 0.3.0-preview.14on/health, in the Agent Channel handshake (server_release), and in the Hermes integration bundle URL built inagent-employees.ts. That env default beats the in-code fallback inapps/api/src/lib/agent-channel.ts, which release prep (#319) already bumped to preview.15.The fix leaves the arg empty so the in-code fallback applies. The release workflow still passes the exact version (
release.yml,DEFT_RELEASE_VERSION=${{ steps.release.outputs.version }}), so published images are unaffected.Observed on a source build of
1427f66:/health→{"release":"0.3.0-preview.14","commit":"unknown","schema_head":"0.3.0-preview.29",…}.Type
Test plan
scripts/release-workflow.test.mjs: the Dockerfile must not pin aDEFT_RELEASE_VERSIONdefault, and the release workflow must keep passing it.node --test scripts/release-workflow.test.mjs: 16/16 on the branch, 15/16 onmaster(the new case fails).Residual note
commitstaysunknownfor source builds because nothing passesVCS_REF. Wiringgit rev-parseinto compose is a separate decision, so it is left out here.Related issues
None found (searched open and closed issues and PRs).