docs(issues): own gap inventory, split into fix vs add - #71
Merged
Merged
Conversation
Twenty items, each with an internal file:line referent and a measured number, sorted by cost/benefit rather than by importance. F (fix): the product returns no typed degraded states, so an empty result is indistinguishable from a failed check (F1); there is no exact runtime guard on the MCP surface, only a floor that importorskip can remove (F2a); seven names in the write-annotation set are never registered (F2b); the layer bucket labelled transitional cannot block and has no expiry (F3); the suite that proves every guard can fail is wired into neither CI nor pre-commit (F4); the protocol guard is currently red with seven findings and unmonitored (F5); three confirmed doc/code drifts (F6). A (add): per-row freshness proof at the retrieval boundary (A1); generated agent prompt with a build hash (A2); hard negatives required by the frozen manifest schema (A3); schema snapshot for action discriminators (A4); a counter for the line-based parser fallback, which is currently unmeasured (A5); fail-closed behaviour when the project root is unset (A6); one recorded mutmut run (A7). Also records what not to adopt: shrinking to 8 mega-tools, a JSON vector store with a lexical prefilter, and an offline memory harness with no production consumer - all three are regressions against what we already have.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A dry, self-referential gap inventory appended to
ISSUE.md. No external attribution: every referent is internal (file:line), every number comes from a command run in this repo.Twenty items, split into F — fix what is ours and A — add what we do not have at all, plus an explicit list of things not to adopt.
Why these twenty
The list came from measuring this repo against itself rather than against a wish list: which gates are wired into nothing, which numbers in the docs cannot be produced by today's command, which guards are red, and which affordances exist only as prose.
The seven that matter most
check_t10/check_t11have no test assertion at allscripts/audit_protocol_guards.py:66,87-98server_tools.py:6,10·.githooks/pre-commit:8-16·run_all.py:71-73search_tools.py:197,607importorskip, the other counts texttest_mcp_schema_flat.py:38·auto_doc_updater.py:459run_all.py, the "prove every guard can fail" suite, is opt-intools/verification/run_all.py.github/workflows/ci.ymlfrozen_overlap_check.pyDeliberately not adopted
Recorded in the file so nobody re-litigates it: shrinking 65 tools to 8 mega-tools (size is not protection without a discriminator guard), a JSON vector store with a lexical prefilter (we are already on LanceDB with an IVF guard), and an offline memory harness with no production caller.
Verification
Not verified: nothing in this PR is executable code, so there is nothing to run. The claims are read-level claims about the current tree and are falsifiable by the referenced file:line.